Thread (10 messages) flat view 10 messages, 3 authors, 2021-06-07

Re: [PATCH 2/2] read-cache: fix incorrect count and progress bar stalling

From: Derrick Stolee <hidden>
Date: 2021-06-07 15:31:19

On 6/7/2021 10:43 AM, Ævar Arnfjörð Bjarmason wrote:
Fix a potential incorrect display of the number of items (off by one)
and stalling of the progress bar in refresh_index().

The off-by-one error is minor, we should say we're processing the 1st
item, not the 0th. This along with the next change also allows us to
remove the last display_progress() call outside the loop, as we'll
always have reached 100% now.
This "pre-announce the progress" seems correct and is unlikely
to have a user sitting at "100%" while the loop is actually doing
work on that last cache entry.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help