Re: [PATCH v2 try2 0/4] completion: bash: a bunch of fixes

On Sun, Jun 6, 2021 at 11:51 AM Felipe Contreras
[off-list ref] wrote:

These should be pretty obvious and straightforward.

This is the second time I'm sending this exact series, and the seventh time in almost
exactly the same form.

The previous version was still applying without conflicts to master, and so does this one.

 * https://lore.kernel.org/git/xmqqv9cavcc5.fsf@gitster.c.googlers.com/ (local)
 * https://lore.kernel.org/git/6094a335c22dc_8ee520860@natae.notmuch/ (local)

Felipe Contreras (4):
  completion: bash: fix prefix detection in branch.*
  completion: bash: fix for suboptions with value
  completion: bash: fix for multiple dash commands
  completion: bash: add correct suffix in variables

 contrib/completion/git-completion.bash | 14 +++++++-------
 t/t9902-completion.sh                  | 15 +++++++++++++++
 2 files changed, 22 insertions(+), 7 deletions(-)

Range-diff:
1:  dd49b0e680 ! 1:  52de92cb06 completion: bash: fix prefix detection in branch.*
    @@ Commit message

           git clone --config=branch.<tab>

    +    Reviewed-by: SZEDER Gábor [off-list ref]
         Signed-off-by: Felipe Contreras [off-list ref]

      ## contrib/completion/git-completion.bash ##
2:  6ac184b9a4 = 2:  af2f17364d completion: bash: fix for suboptions with value
3:  960a692fda = 3:  a3bcb70594 completion: bash: fix for multiple dash commands
4:  a95c3edaf9 = 4:  6b3ef41c92 completion: bash: add correct suffix in variables
--
2.31.1.2.g0532ba4bf6

I tested this series on:
- GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
- GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)
- zsh 5.0.2 (x86_64-redhat-linux-gnu)
- zsh 5.7.1 (x86_64-apple-darwin19.0)
and can confirm that it is an improvement.

FWIW,
Tested-by: David Aguilar <redacted>

cheers,
-- 
David