Torsten Bögershausen [off-list ref] writes:
This all looks good.
Some suggestions about the commit message are inline.
All good comments.
I have another one on the title.
Subject: Re: [PATCH v2] t: use user-specific utf-8 locale for testing
If we auto-detect to customize which locale to use per user, that is
already user-specific; letting the user to explicitly tell us which
locale to use, that is "use user-specified UTF-8 locale".
This affects only SVN tests and the change is in lib-git-svn, so
when we test other parts of the system for UTF-8, this change will
not directly help, right? Perhaps we want to mention SVN somewhere
on the title? Perhaps "for testing git-svn"?
Thanks.