Thread (12 messages) flat view 12 messages, 4 authors, 2021-06-06

Re: [PATCH] parallel-checkout: use grep -c to count workers in tests

From: René Scharfe <hidden>
Date: 2021-06-05 15:30:15

Am 05.06.21 um 17:20 schrieb René Scharfe:
Am 05.06.21 um 16:31 schrieb Matheus Tavares Bernardino:
quoted
On Sat, Jun 5, 2021 at 9:27 AM René Scharfe [off-list ref] wrote:
Just one
minor nit: I think we could drop the redirection as grep can take the
file name as an argument.
I'm not sure if there's a grep out there that prints the filename before
the count even if it deals with a single file.  git grep does that, at
least.  POSIX[3] implies the lack of filename prefix for the single file
case, but I don't know if we can rely on that everywhere.

[3] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html
Except we got plenty of "grep -c" calls with a single filename and no
redirection in t/ already.  Adding one more should be fine.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help