Thread (26 messages) flat view 26 messages, 7 authors, 2021-06-22

Re: [PATCH 3/3] cmake: add warning for ignored MSGFMT_EXE

From: Eric Sunshine <hidden>
Date: 2021-06-04 18:10:21

On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget
[off-list ref] wrote:
It does not make sense to attempt to set MSGFMT_EXE when NO_GETTEXT is
configured, as such add a check for NO_GETTEXT before attempting to set
it.
This would be easier to digest if "as such" is the start of a new
sentence: "As such...". Or "Therefore, add a check...".
suggested-by: Johannes Schindelin <redacted>
Signed-off-by: Matthew Rogers <redacted>
s/suggested-by/Suggested-by:/

Tiny little nits, both. Don't know if it's worth a re-roll, but if you
happen to re-roll for some other reason, perhaps these could be
tweaked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help