Thread (15 messages) flat view 15 messages, 3 authors, 2021-06-03

Re: [PATCH 1/2] [GSOC] cat-file: fix --batch report changed-type bug

From: Jeff King <hidden>
Date: 2021-06-03 19:28:45

On Thu, Jun 03, 2021 at 03:18:43PM +0800, ZheNing Hu wrote:
Jeff King [off-list ref] 于2021年6月3日周四 上午4:01写道:
quoted
  This assumption was broken by 845de33a5b (cat-file: avoid noop calls
  to sha1_object_info_extended, 2016-05-18). That commit skips the call
  to oid_object_info_extended() entirely when --batch-all-objects is in
  use, and the custom format does not include any placeholders that
  require calling it.
Or when the custom format only include placeholders like %(objectname) or
%(rest), oid_object_info_extended() will not get the type of the object.
Yeah, that's what I was trying to get at with "placeholders that require
calling it", but I couldn't think of a less awkward way to say that. :)
Spelling it out is probably a good idea.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help