On Wed, Jun 02, 2021 at 04:14:27PM -0400, Jeff King wrote:
quoted
The wrapper should apply to all platforms. NFS (and presumably
other network FSes) can be mounted with interrupts enabled.
I don't mind that, as the wrapper is pretty low-cost (and one less
Makefile knob is nice). If it's widespread, though, I find it curious
that nobody has run into it before now.
Yeah, I find it curious as well. I agree that the wrapper is relatively
cheap (especially relative to fsync), but it seems unnecessary despite
what's in POSIX's fsync(3). So the more conservative choice to me would
be to hide it behind a Makefile knob, but I don't mind much either way.
Thanks,
Taylor