Re: [PATCH][GSoC] submodule: introduce add-clone helper for submodule add

From
Atharva Raykar <hidden>
Date
2021-06-02 08:19:01
Reply to
Atharva Raykar, 2021-06-02
On 02-Jun-2021, at 13:25, Atharva Raykar [off-list ref] wrote:

[...]
I've not yet fully developed a taste for good C style, so I wanted
to ask, which one looks better to you in these?

/* Sample 1 */
while (begin != end && (line = get_next_line(begin, end))) {
	char *name, *url, *tail;
	name = parse_token(&begin, next_line);
	url = parse_token(&begin, next_line);
	tail = parse_token(&begin, next_line);
	...
}

/* Sample 2 */
while (begin != end && (line = get_next_line(begin, end))) {
	char *name = parse_token(&begin, next_line);
	char *url = parse_token(&begin, next_line);
	char *tail = parse_token(&begin, next_line);
	...
}
Also ignore the error here, assume: s/next_line/line/
(Anyway, my question was about style)
Thread (11 messages) 11 messages, 3 authors, last reply 2021-06-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help