On 2021-05-31 14:49:32+0700, Bagas Sanjaya [off-list ref] wrote:

Hi Đoàn,

On 31/05/21 13.47, Đoàn Trần Công Danh wrote:

quoted

On 2021-05-31 06:00:56+0000, Andy AO via GitGitGadget [off-list ref] wrote:

quoted

From: zen96285 <redacted>

The git log documentation says "The default option is 'short'." This is wrong. After testing, the default value of '--decorate' is 'auto', not 'short'.

There is no difference between 'auto' and 'short' in terminal, but there is a significant difference in how they behave in the shell.The information generated by the 'short' can be saved in shell variables, while the 'auto' can't.

Please use your real name and wrap your commit message at 50
characters for subject line and 72 characters for body.

I think the case here was Andy forwarded this patch from someone, which
happened to be also himself. Maybe that From: line above can be removed,
unless that he forwarded from other people (in which From: line must be
preserved).

Andy is using GitGitGadget bridge.
That bridge uses its own email address (gitgitgadget@gmail.com).

Thus, the identity in the RFC 822's header: "From" should be ignored,
and we should use the "From: " line in body instead.

In principle, GitGitGadget will use the Author identity in the commit
that was pushed into GitHub to generate such "From: " line.
So, it's Andy's resposibility to configure correct core.name and
core.email in Andy's machine, and create a commit with correct
authorship. Otherwise, GitGitGadget will create above message.

Hope that help.

-- 
Danh