Re: [PATCH v2 00/12] doc: cleanup old cruft and asciidoctor revamp
From: Felipe Contreras <hidden>
Date: 2021-05-25 10:44:58
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
From: Felipe Contreras <hidden>
Date: 2021-05-25 10:44:58
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Junio C Hamano wrote:
Felipe Contreras [off-list ref] writes:quoted
Apparently my scripts call `git format-patch` with -D, which doesn't generate appliable patches when files are deleted.Don't call format-patch with -D, then ;-).
I won't. I've fixed it now [1].
quoted
Do you want me to send it again without -D?Sure, if a collection of patches want to be reviewed and applied, I would think it helps for them to be appliable to a common tree (like my 'master') with tools reviewers and the maintainer are know to use (like "git am"). As more roadblocks are added before the changes can become reviewable in the reviewers' trees, less chances they have to get reviewed.
I think this is reviewable:
diff --git a/Documentation/manpage-quote-apos.xsl b/Documentation/manpage-quote-apos.xsl
deleted file mode 100644
But yeah, could be more reviewable. [1] https://github.com/felipec/git-send-series/commit/0f4bbf90fdd224e3d5253332755ad3d45c862ee4 -- Felipe Contreras