Re: [PATCH v4] help: colorize man pages

On 22/05/2021 10:55, Jeff King wrote:

On Fri, May 21, 2021 at 04:40:30PM -0500, Felipe Contreras wrote:

quoted

Jeff King wrote:

quoted

On Fri, May 21, 2021 at 01:01:35PM -0500, Felipe Contreras wrote:

quoted

quoted

I still don't understand what we gain by making this a Git feature,

What do we gain by making `git diff` output color?

Huh? Git is outputting the diff. Who else would output the color?

Do you think our users know or care which binary has the final
connection to the tty?

Yes. If we are telling them that "git help git" is using "man", which we
do, then I think they should expect it to behave like "man".

Moreover, I think that if they like colorized manpages, they'd probably
want them when running "man" themselves.

-Peff

And we have the whole Git for Windows community who don't have `man`
anyway...
It's a bit of a conundrum, especially when considering all the
'terminals' Windows folk maybe using.