Thread (8 messages) flat view 8 messages, 4 authors, 2021-05-22

Re: Bug in git submodule update --remote

From: Christian Couder <hidden>
Date: 2021-05-21 18:36:38

On Fri, May 21, 2021 at 1:47 PM Atharva Raykar [off-list ref] wrote:
On 19-May-2021, at 20:11, Ben Avison [off-list ref] wrote:
quoted
I like that solution. Although, I should note that if the user has set
submodule.<name>.remote to something other than 'origin', they will need
to ensure that submodule.<name>.branch is also set, or they will still
hit the "Unable to find current <remote>/HEAD revision in submodule"
error that I initially stumbled on.

How about an implementation like the following? I introduced a new "git
submodule--helper" command rather than modify "print-default-remote" for
a couple of reasons:
First thanks for taking a look at improving git submodule and for
doing so by introducing most of the new code in submodule--helper!

[...]
Since this would modify the behaviour of the update subcommand, I
have decided to CC my mentors (Christian and Shourya) who are more
qualified than me to comment on this proposal.
As commit f0a96e8d's author is Dscho (Johannes Schindelin) and as he
was helped by Philippe Blain, let me CC them too. They might know the
reasons for this behavior better than us.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help