Thread (5 messages) flat view 5 messages, 3 authors, 2021-05-20

Re: [PATCH] fetch: improve grammar of "shallow roots" message

From: Alex Henrie <hidden>
Date: 2021-05-20 04:02:38

On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya [off-list ref] wrote:
On 18/05/21 13.18, Alex Henrie wrote:
quoted
-                                     warning(_("reject %s because shallow roots are not allowed to be updated"),
+                                     warning(_("rejected %s because shallow roots are not allowed to be updated"),
 From descriptive to null-subject past tense, right?
I'm not sure what the best way is to describe the grammar here. I
would say that the "ed" makes it clear that the message is a
description of what did happen rather than an imperative command
concerning what should happen.

-Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help