Thread (1 message) 1 message, 1 author, 2021-05-12

Re: [PATCH v3 4/8] t7300: add testcase showing unnecessary traversal into ignored directory

From: Junio C Hamano <hidden>
Date: 2021-05-12 03:17:58

Elijah Newren [off-list ref] writes:
If you'd like, I can add another patch in the series with this change
so that all readdir() calls in dir.c have such ignore '.' and '..'
logic.  Or, we could perhaps introduce a new readdir() wrapper that
does nothing other than ignore '.' and '..' and have all three of
these callsites use that new wrapper.
Yeah, it is good to be consistent (either implementation).
quoted
So dropping the test for number of visited paths would be nicer from
portability's point of view ;-)
Yep, makes sense.  I already did that in v4, which means it'll
continue to pass with or without the above proposed change to
read_cached_dir().
Yup.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help