Thread (4 messages) flat view 4 messages, 2 authors, 2021-05-11

Re: [PATCH] git-send-email: use ! to indicate relative path to command

From: Jeff King <hidden>
Date: 2021-05-11 19:11:53

On Tue, May 11, 2021 at 01:03:32PM -0600, Gregory Anders wrote:
I also noticed this after some quick testing and just sent a v2 right before
seeing your reply.

Your (untested) implementation seems much cleaner than mine, and I'm happy
to give that a try. Question: is it okay that we pass just a raw command
name to exec instead of a full path? That is, is there any reason we need to
first find the command in PATH *and then* pass it to exec (which is what my
v2 implementation does)?
I don't think so. Perl's exec() should do the PATH lookup itself. I was
surprised not to see this mentioned explicitly in the documentation, but
it clearly does work. E.g., try:

  perl -e 'exec("ls")'

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help