Re: [PATCH v2 1/1] maintenance: use systemd timers on Linux
flat view
From: Martin Ågren <hidden>
Date: 2021-05-10 19:15:31
Hi Lénaïc, On Sun, 9 May 2021 at 23:37, Lénaïc Huard [off-list ref] wrote:
The default value is `auto` which chooses a suitable scheduler for the system. On Linux, if user systemd timers are available, they will be used as git maintenance scheduler. If not, `cron` will be used if it is available. If none is available, it will fail.
I understand your reasoning for going with systemd-timer over cron, especially the part about knowing that the thing is actually running.
+--scheduler=auto|crontab|systemd-timer|launchctl|schtasks::
This says "systemd-timer"...
quoted hunk ↗ jump to hunk
+ By default or when `auto` is specified, the most appropriate scheduler + for the system is used. On MacOS, `launchctl` is used. On Windows, + `schtasks` is used. On Linux, `systemd-timers` is used if user systemd
... this says "systemd-timers". Should those two be the same? (Which?)
+ timers are available, otherwise, `crontab` is used. On all other systems, + `crontab` is used.
So to be clear, I don't have a horse in this race. A few years ago I would have foreseen all kinds of reactions to the implication that systemd-timers would be "the most appropriate scheduler [...] on Linux". Maybe those times are behind us now. In the commit message, you say "a suitable", which reads a little bit less opinionated (to me). That's just a minor point; feel free to disregard.
+For more details, see systemd.timer(5)
Missing trailing ".". A cursory grepping of our docs suggests this should be monospace (`systemd.timer(5)`). There aren't that many places where we refer to non-git manpages, thanks for doing so. That's the only nit I found to make about the markup in the documentation. Thanks for your attention to details. :-) Martin