Re: [PATCH] [GSOC] pretty: provide human date format

Hi ZheNing,

On Fri, Apr 23, 2021 at 04:27:25PM +0000, ZheNing Hu via GitGitGadget wrote:

From: ZheNing Hu <redacted>

Add the placeholders %ah and %ch to format author date and committer
date, like --date=human does, which provides more humanity date output.

I don't see a reason why this shouldn't exist, and the patch that you
wrote below looks pretty good to me.

To refresh my memory on if you had missed any spots, I followed
0df621172d (pretty: provide short date format, 2019-11-19) as an
example. You did a fine job here, and I don't think this patch is
missing anything.

Signed-off-by: ZheNing Hu <redacted>
---
    [GSOC] pretty: provide human date format

    Reasons for making this patch: --date=human has no corresponding
    --pretty option.

    Although --date=human with --pretty="%(a|c)d" can achieve the same
    effect with --pretty="%(a|c)h", but it can be noticed that most time
    formats implement the corresponding option of --pretty, such as
    --date=iso8601 can be replaced by --pretty=%(a|c)i, so add
    "--pretty=%(a|c)h" seems to be a very reasonable thing.

Just to make sure I understand what you wrote: you're saying that the
pretty formats "%ah" and "%ch" that you propose here could be achieved
with --date=human and --pretty="%ad". Makes sense, but I agree that your
point about --date=iso8601 having a built-in pretty atom makes the case
for having "%ah" and "%ch".

There's no sorting here, so this place (at the bottom of the author-date
placeholders) seems just as good as any.

Likewise. The rest all looks good to me, too.

  Reviewed-by: Taylor Blau [off-list ref]

Thanks,
Taylor