Re: [PATCH 04/18] t1401-symbolic-ref: avoid direct filesystem access

On Fri, Apr 23, 2021 at 9:47 AM Han-Wen Nienhuys [off-list ref] wrote:

On Fri, Apr 23, 2021 at 7:12 AM SZEDER Gábor [off-list ref] wrote:

quoted

quoted

I see it as the test writer's job to clean up to the extent that
git-symbolic-ref can reset to a sane state.

No, it's the job of whoever updates the cleanup routine to make sure
that the updated cleanup routine still works just as well as it did in
the past.

Sorry, I don't mean to shirk my responsibility. What I mean is: is
there a way to signal "This test is fubar. Stop further execution of
test shell script".

Or, more generally: if a cleanup routine fails, what is the point of
continuing to run the test script? If that happens, the test directory
is an indeterminate state, so the outcome of follow-on test-functions
is indeterminate as well.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado