Thread (1 message) 1 message, 1 author, 2021-04-18

Re: [PATCH] git-merge: move space to between strings

From: Junio C Hamano <hidden>
Date: 2021-04-18 19:18:40

"Josh Soref via GitGitGadget" [off-list ref] writes:
From: Josh Soref <redacted>

Signed-off-by: Josh Soref <redacted>
---
    git-merge: move space to between strings
    
    GitHub Actions show things like:
    
     * branch                  master     -> FETCH_HEAD
     (nothing to squash)Already up to date.
    
    
    The expected results are:
    
     * branch                  master     -> FETCH_HEAD
    (nothing to squash) Already up to date.
I am not sure if that is THE expected results, though (you wouldn't
have got this reaction if you said "I would expect to see").  

Usually, it is easier to read a message if it makes its primary
point first, before giving a parenthetical note.  I.e.  I would
expect that

	Already up to date (nothing to squash).

would be easier to understand to users.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help