Re: [PATCH v6 04/20] reftable: utility functions

On Tue, Apr 13, 2021 at 10:02 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Mon, Apr 12 2021, Han-Wen Nienhuys via GitGitGadget wrote:

quoted

+int strbuf_add_void(void *b, const void *data, size_t sz)
+{
+     strbuf_add((struct strbuf *)b, data, sz);
+     return sz;
+}

Is that cast needed on your compiler? This compiles without warnings for
me without that.

No! thanks.

Also, maybe this is the sort of thing that makes sense to split into
general "APIs needed for reftable" patches. E.g. something like the
below (just the strbuf.h change):

SGTM.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado