Thread (1 message) 1 message, 1 author, 2021-04-12

Re: [PATCH 14/16] test-lib-functions: use "return 1" instead of "false"

From: Junio C Hamano <hidden>
Date: 2021-04-12 19:31:53

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
Change a few functions that relied on a "false" being the last
statement in the function to use an explicit "return 1" like the other
functions in this file.
While not wrong per-se, this and a few other changes in this series
are typical of your multi-patch series that unnecessarily consume
reviewer bandwidth that could be better spent on other more
important and correctness sensitive steps (like 07/16) in the same
series.

You should find a good balance to avoid wearing out and distracting
your reviewers---they are the most scarce resource around here that
must be shared by other people, not just with other topics of your
own.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help