Thread (1 message) 1 message, 1 author, 2021-04-12

Re: [PATCH 01/16] check-non-portable-shell: complain about "test" a/-o instead of &&/||

From: Junio C Hamano <hidden>
Date: 2021-04-12 18:36:44

Matthieu Moy [off-list ref] writes:
And also in Git's Documentation/CodingGuidelines, which motivates the advice with an example:

     test -n "$x" -a "$a" = "$b"

   is buggy and breaks when $x is "=", but

     test -n "$x" && test "$a" = "$b"

   does not have such a problem.
Good advice to cite Documentation/CodingGuidelines in the log
message.

Thanks (and nice to hear from you again ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help