Thread (1 message) 1 message, 1 author, 2021-04-09

Re: [PATCH 1/2] blob.c: remove buffer & size arguments to parse_blob_buffer()

From: Junio C Hamano <hidden>
Date: 2021-04-09 22:31:47

Jeff King [off-list ref] writes:
OK. Calling it parse_blob_buffer() is a little silly since it doesn't
even take a buffer anymore. But I guess parse_blob() might imply that it
actually loads the contents from disk to check them (which the other
parse_foo() functions do), so that's not a good name.
mark_object_as_parsed(), perhaps?
So this might be the least bad thing. Given that there are only two
callers, just setting blob->object.parsed might not be unreasonable,
either. But I don't think it's worth spending too much time on.
Yup.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help