Thread (1 message) 1 message, 1 author, 2021-03-31

Re: [PATCH v9] builtin/clone.c: add --reject-shallow option

From: Junio C Hamano <hidden>
Date: 2021-03-31 22:38:17

Johannes Schindelin [off-list ref] writes:
quoted
Does this "single variable is enough" really work?
...
That's my mistake, and you don't even need a second config to see the
problem:

	[clone]
		rejectShallow = false
		rejectShallow = true
Yup, that is a much simpler example.
Sorry for the trouble!
Don't feel bad---in an earlier round of review I made a similar
mistake to wonder if these two variables can be reduced into one
myself ;-).  As you said, this one is special in making two calls to
git_config() and need to be handled carefully.

Thanks.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help