Thread (19 messages) 19 messages, 4 authors, 2021-04-08

Re: [GSOC][PATCH] userdiff: add support for Scheme

flat view

From: Johannes Sixt <hidden>
Date: 2021-03-29 10:49:05

Am 29.03.21 um 12:18 schrieb Phillip Wood:
It would be nice to include indented define forms but including them
means that any change to the body of a function is attributed to the
last internal definition rather than the actual function. For example

(define (f arg)
  (define (g x)
    (+ 1 x))

  (some-func ...)
  ;;any change here will have '(define (g x)' in the hunk header, not
'(define (f arg)'

I don't think this can be avoided as we rely on regexs rather than
parsing the source so it is probably best to only match toplevel defines.
There can be two rules, one that matches '(define-' that is indented,
and another one that matches all non-indented forms of definitions. If
that is what you mean.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help