Re: Re: [PATCH 2/2] remote-curl.c: handle v1 when check_smart_http

On Mon, Mar 29, 2021 at 05:30:29PM +0800, lilinchao@oschina.cn wrote:

quoted

Anyway, that's all just an interesting side note. The client is happy
with either form (though it might be nice if we had tests for the "#
service" form; I suspect our tests don't cover that because they are all
using http-backend).

Getting back to the patch at hand, if there is a server saying "version
1" without a "service" line, then I think that is a bug in that server.

If the problem is on the server side, then, is this patch worth continuing?

IMHO, no. I think the response from gitee.com is violating the protocol
spec. It would be nice to fix, but in practice it isn't all that
important because somebody would have to manually set protocol.version=1
to see the problem.

-Peff