Re: [PATCH 1/2] transport.c: modify comment in transport_get().
From: Junio C Hamano <hidden>
Date: 2021-03-24 20:23:53
lilinchao@oschina.cn writes:
quoted hunk
From: lilinchao <redacted> Signed-off-by: lilinchao <redacted> --- transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/transport.c b/transport.c index 1c4ab676d1..71b3d44cf3 100644 --- a/transport.c +++ b/transport.c@@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url) data->conn = NULL; data->got_remote_heads = 0; } else { - /* Unknown protocol in URL. Pass to external handler. */ + /* Http/https and other unknown protocol in URL. Pass to external handler. */
The previous block says /* * These are builtin smart transports; "allowed" transports * will be checked individually in git_connect. */ where it lists file:// git:// and ssh:// URLs. And contrasting with that, it should be clear "unknown" refers to "not a builtin that is known to the C code linked to the same binary" and includes http:// and https://. IOW, I am not sure adding "http/https and other" to make it an overlong line is worth doing. Thanks.