Hi Johannes,

Le 22/03/2021 à 22:59, Johannes Schindelin a écrit :

Hi Alban,

On Wed, 17 Mar 2021, Alban Gruin wrote:

quoted

This moves the function add_cacheinfo() that already exists in
update-index.c to update-index.c, renames it add_to_index_cacheinfo(),
and adds an `istate' parameter.  The new cache entry is returned through
a pointer passed in the parameters.  The return value is either 0
(success), -1 (invalid path), or -2 (failed to add the file in the
index).

This paragraph still talks about magic numbers, but the code has constants
for them. Maybe elevate the commit message to a more generic description
that does not spend time on specifying the exact values, but rather lists
the three outcomes in plain English?

Okay, I'll do this.

Cheers,
Alban

Other than that, this looks fine to me! Thanks,
Dscho