Re: [PATCH] rebase: remove transitory rebase.useBuiltin setting & env
From: Junio C Hamano <hidden>
Date: 2021-03-23 20:43:12
Ævar Arnfjörð Bjarmason [off-list ref] writes:
It's been more than long enough for those users to get a headsup about this. So remove all the scaffolding that was left inplace after d03ebd411c6. I'm also removing the documentation entry, if anyone still has this left in their configuration they can do some source archaeology to figure out what it used to do, which makes more sense than exposing every git user reading the documentation to this legacy configuration switch.
OK, this concludes the long journey of replacing the scripted "git rebase" with its reimplementation in C by removing the last trace of the former. It would be nice to have Acks from those involved in the reimplementation effort, to celebrate the occasion.
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- Documentation/config/rebase.txt | 7 ------- builtin/rebase.c | 11 ----------- t/t3400-rebase.sh | 16 ---------------- 3 files changed, 34 deletions(-)diff --git a/Documentation/config/rebase.txt b/Documentation/config/rebase.txt index 214f31b451f..8c979cb20f2 100644 --- a/Documentation/config/rebase.txt +++ b/Documentation/config/rebase.txt@@ -1,10 +1,3 @@ -rebase.useBuiltin:: - Unused configuration variable. Used in Git versions 2.20 and - 2.21 as an escape hatch to enable the legacy shellscript - implementation of rebase. Now the built-in rewrite of it in C - is always used. Setting this will emit a warning, to alert any - remaining users that setting this now does nothing. -