Thread (1 message) 1 message, 1 author, 2021-03-23

Re: [PATCH v3 0/2] diff --no-index: fix test blind spots

From: Junio C Hamano <hidden>
Date: 2021-03-23 16:48:15

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
Since v2[1]: s/echo -n/printf/ (and I re-adjusted my test setup to run
the linting..)

1. https://lore.kernel.org/git/cover.1616366036.git.avarab@gmail.com/ (local)

Ævar Arnfjörð Bjarmason (2):
  diff --no-index tests: add test for --exit-code
  diff --no-index tests: test mode normalization

 t/t4053-diff-no-index.sh | 60 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

Range-diff:
1:  2dbc6c253e2 = 1:  7dd5c309a70 diff --no-index tests: add test for --exit-code
2:  a1ab6a323f2 ! 2:  e5bb094b783 diff --no-index tests: test mode normalization
    @@ t/t4053-diff-no-index.sh: test_expect_success 'diff --no-index allows external d
     +test_expect_success POSIXPERM,SYMLINKS 'diff --no-index normalizes: mode not like git mode (symlink)' '
     +	ln -s y z &&
     +	X_OID=$(git hash-object --stdin <x) &&
    -+	Z_OID=$(echo -n y | git hash-object --stdin) &&
    ++	Z_OID=$(printf "y" | git hash-object --stdin) &&
     +	cat >expected <<-EOF &&
     +	diff --git a/x b/x
     +	deleted file mode 100644
Thanks for a quick turnaround, and sorry for forgetting to say
"locally munged, no need to resend".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help