Thread (83 messages) 83 messages, 10 authors, 2021-03-27

Re: [PATCH v4 1/4] Makefile/coccicheck: add comment heading for all SPATCH flags

From: René Scharfe. <hidden>
Date: 2021-03-22 18:05:12

Am 22.03.21 um 13:11 schrieb Ævar Arnfjörð Bjarmason:
In 960154b9c17 (coccicheck: optionally batch spatch invocations,
2019-05-06) the comment being re-added here was amended and reworded
to apply to the SPATCH_BATCH_SIZE variable.

If we'd like a separate comment on SPATCH_FLAGS now the diff to
introduce it will need to also move the comment.
None of the patches in this series do actually add a separate comment.
So SPATCH_FLAGS could stay where it is, no?
quoted hunk ↗ jump to hunk
So add this heading
back to make subsequent diffs smaller.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f3dc2178324..eef99b4705d 100644
--- a/Makefile
+++ b/Makefile
@@ -1198,10 +1198,11 @@ PTHREAD_CFLAGS =
 SPARSE_FLAGS ?=
 SP_EXTRA_FLAGS = -Wno-universal-initializer

+# For the 'coccicheck' target
+SPATCH_FLAGS = --all-includes --patch .
 # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will
 # usually result in less CPU usage at the cost of higher peak memory.
 # Setting it to 0 will feed all files in a single spatch invocation.
-SPATCH_FLAGS = --all-includes --patch .
 SPATCH_BATCH_SIZE = 1

 include config.mak.uname
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help