Re: [PATCH v10 2/3] interpret-trailers: add own-identity option

Đoàn Trần Công Danh [off-list ref] 于2021年3月19日周五 上午12:45写道：

On 2021-03-18 11:15:55+0000, ZheNing Hu via GitGitGadget [off-list ref] wrote:

quoted

From: ZheNing Hu <redacted>

Beacuse `git commit --trailer="Signed-off-by: \

s/Beacuse/Because/

And I think, it's easier to read if we write the command in its own
(indented) line.

quoted

$(git config user.name) <$(git config user.email)>"`
is difficult for users to add their own identities,
so teach interpret-trailers a new option `--own-identity`
which allow those trailers with no value add the user’s own
identity. This will help the use of `commit --trailer` as
easy as `--signoff`.

Perhap, saying that we're optionalise <value> in --trailer, by
substitute user's identity if missing instead?

Indeed so.

quoted

@@ -131,6 +144,7 @@ OPTIONS
      when you know your input contains just the commit message itself
      (and not an email or the output of `git format-patch`).

+

I think it's better to not add this line change

quoted

 CONFIGURATION VARIABLES
 -----------------------

diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c
index 84748eafc01b..be7f502a58d7 100644
--- a/builtin/interpret-trailers.c
+++ b/builtin/interpret-trailers.c

Thanks for these kindful advices.

--
Danh

--
ZheNing Hu