Thread (2 messages) 2 messages, 2 authors, 2021-03-17

Re: [PATCH 5/7] Makefile: add 'check-sort' target

flat view

From: Junio C Hamano <hidden>
Date: 2021-03-17 18:02:48

Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
+	./check-sort.perl '\t\{ "[^"]*",' <git.c
This last one you can IMO be done better as (or if we want to be more
anal, we could make git die on startup if it's not true):
    
    diff --git a/t/t0012-help.sh b/t/t0012-help.sh
    index 5679e29c62..5bd2ebceca 100755
    --- a/t/t0012-help.sh
    +++ b/t/t0012-help.sh
    @@ -77,6 +77,11 @@ test_expect_success 'generate builtin list' '
            git --list-cmds=builtins >builtins
     '
     
    +test_expect_success 'list of builtins in git.c should be sorted' '
    +       sort builtins >sorted &&
    +       test_cmp sorted builtins
    +'
"LANG=C LC_ALL=C sort ..."

I like this 100% better than the original ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help