Thread (193 messages) flat view 193 messages, 3 authors, 2021-03-21

Re: [PATCH v3 0/9] read_tree() and read_tree_recursive() refactoring

From: Elijah Newren <hidden>
Date: 2021-03-16 05:38:47

On Mon, Mar 15, 2021 at 4:44 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:
A v3 of a refactoring of tree.c. See v2 at
https://lore.kernel.org/git/20210308022138.28166-1-avarab@gmail.com/ (local)

This brings back pretty much the old read_tree_recursive() under the
name read_tree_at() as suggested in
https://lore.kernel.org/git/xmqqft106sok.fsf@gitster.g/ (local)
Patch 8/9 was a bit harder for me to read; I'm not sure if that means
the patch needs improvement or just reflects a personal failing.  :-)
But ultimately, it's minor and the rest of the series looks good.
With or without a few tweaks to that patch:

Reviewed-by: Elijah Newren <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help