Thread (2 messages) 2 messages, 2 authors, 2021-03-15

Re: [PATCH] block-sha1: drop trailing semicolon from macro definition

flat view

From: Jonathan Nieder <hidden>
Date: 2021-03-15 23:08:18

René Scharfe. wrote:
23119ffb4e (block-sha1: put expanded macro parameters in parentheses,
2012-07-22) added a trailing semicolon to the definition of SHA_MIX
without explanation.  It doesn't matter with the current code, but make
sure to avoid potential surprises by removing it again.

This allows the macro to be used almost like a function: Users can
combine it with operators of their choice, but still must not pass an
expression with side-effects as a parameter, as it would be evaluated
multiple times.

Signed-off-by: René Scharfe <redacted>
---
 block-sha1/sha1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <redacted>
Yes, it was just a typo.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help