Thread (5 messages) 5 messages, 3 authors, 2021-03-15

Re: [PATCH v4 2/6] commit: add amend suboption to --fixup to create amend! commit

flat view

From: Eric Sunshine <hidden>
Date: 2021-03-15 08:17:37

On Mon, Mar 15, 2021 at 3:59 AM Charvi Mendiratta [off-list ref] wrote:
On Mon, 15 Mar 2021 at 04:37, Eric Sunshine [off-list ref] wrote:
quoted
Likewise. If you're going to re-roll anyhow, the open-coded:
would be perfectly fine with me too (or any simple variation on that
theme). Whether or not it's worth re-rolling again, I leave up to you
and Junio.
okay, I agree too. I have updated it in the re-roll.

Thanks for all the detailed reviews and suggestions.
Thanks for patiently putting up with reviewers who sometimes have
opposing or contradictory opinions and recommendations.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help