Re: [PATCH v4] [GSOC] commit: add --trailer option

Junio C Hamano [off-list ref] 于2021年3月15日周一 上午7:52写道：

IOW this part would become ...

        if (trailer_args.nr) {
                strvec_pushl(&run_trailer.args, "interpret-trailers",
                             "--in-place", ...);
                strvec_pushv(&run_trailer.args, trailer_args.v);
                run_trailer.git_cmd = 1;
                run_command(&run_trailer);
        }

quoted

+     } else
+             strvec_clear(&run_trailer.args);

... and there is no need to have "else" that won't need to do
anything.

Yes, but we also should clear "trailer_args" in "else" here, and check the
return value of the "run_command()" for clear "run_trailer.args".

quoted

      verbose = -1; /* unspecified */
+     strvec_pushl(&run_trailer.args, "interpret-trailers",
+                 "--in-place", "--where=end", git_path_commit_editmsg(), NULL);

And this line will be gone.

Indeed so.

Thanks.