On Thu, Mar 11, 2021 at 10:27:33AM -0800, Junio C Hamano wrote:
quoted
quoted
* ab/tests-cleanup-around-sha1 (2021-03-10) 4 commits
- tests: get rid of $_x05 from the test suite
- shortlog tests: rewrite to get rid of --abbrev=35 hardcoding
- test-lib: remove unused $_x40 and $_z40 variables
- git-bisect: remove unused SHA-1 $x40 shell variable
FWIW (mostly for other readers) I suggested in
https://lore.kernel.org/git/87tupigf02.fsf@evledraar.gmail.com/ (local) just now
that we drop 4/4.
I do not trust myself; we need to get 2&3 reviewed independently
before we can move beyond discarding the $_x05 step.
Patch 2 looks obviously correct to me (along with 1).
I responded to patch 3. Mostly with nitpicks, though I tend to agree
that the "1-41" magic at least deserves a comment.
I didn't look at patch 4, since it seemed scary and you suggested
dropping it. ;)
-Peff