Re: [PATCH 0/7] rev-parse: implement object type filter
flat view
From: Taylor Blau <hidden>
Date: 2021-03-10 21:58:57
On Mon, Mar 01, 2021 at 01:20:26PM +0100, Patrick Steinhardt wrote:
quoted hunk ↗ jump to hunk
- A new object type filter `--filter=object:type=<type>` for git-rev-list(1), which is implemented both for normal graph walks and for the packfile bitmap index.
I understand what you're looking for here, but I worry that '--filter' might be too leaky of an abstraction. I was a little surprised to learn that you can clone a repository with --filter=object:type=tree (excluding commits), but it does work. I'm fine reusing a lot of the object filtering code if it makes this an easier task, but I think it may be worthwhile to hide this new kind of filter from upload-pack.
quoted hunk ↗ jump to hunk
- Given that above usecase requires two filters (the object type and blob size filters), bitmap filters were extended to support combined filters.
Nice. We didn't do this since the only previously supported filters were blob:none and tree:0 (the latter implying the former), so there was no need. Thanks, Taylor