Thread (3 messages) 3 messages, 3 authors, 2021-03-08

Re: [PATCH] Makefile: generate 'git' as 'cc [...] -o git+ && mv git+ git'

flat view

From: Junio C Hamano <hidden>
Date: 2021-03-07 20:41:57

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
Change the compilation of the main 'git' binary to not have the CC
clobber 'git' in-place. This means that e.g. running the test suite
in-place and recompiling won't fail whatever tests happen to be
running for the duration of the binary being regenerated.
I am not sure why I would want to support the workflow this is
trying to help.

I do not want to see a patch on this list claiming that "While the
whole test suite is running, I tweaked the source three times and
recompiled, so some tests may have used my second iteration while
others may have used my third and the final version of the code---in
any case, all tests passed".  And when a patch that was developed
that way came in, I do not want to hear "Yes, the test suite used
mixed binaries, but I KNOW the difference between my second and
third iteration should not matter the parts of the earlier tests
that used the older iteration".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help