Thread (2 messages) 2 messages, 2 authors, 2021-03-04

Re: [PATCH v3 3/6] commit: add a reword suboption to --fixup

flat view

From: Charvi Mendiratta <hidden>
Date: 2021-03-04 00:22:41

On Tue, 2 Mar 2021 at 00:11, Junio C Hamano [off-list ref] wrote:
[...]
quoted
+     if (argc)
+             die(_("cannot combine reword option of --fixup with path %s"), *argv);
I think our convention is to quote '%s' with a single-quote pair.
See other error messages.

commit.c:                       die_errno(_("could not read '%s'"), templat...
commit.c:               die_errno(_("could not open '%s'"), git_path_commit...
commit.c:       die(_("--author '%s' is not 'Name <email>' and matches no e...
commit.c:               die(_("Invalid ignored mode '%s'"), ignored_arg);
commit.c:               die(_("Invalid untracked files mode '%s'"), untrack...
...
I admit I forgot to add it. I will fix it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help