Thread (12 messages) 12 messages, 3 authors, 2021-03-01

Re: [QUESTION] Tracking HEAD changes?

flat view

From: Yaron Wittenstein <hidden>
Date: 2021-02-25 06:07:00

Thank you for the clarification!

Is there any plan to support such a case in the future?

Also, I've observed that the "post-index-change" hook is being
triggered before calling the "reference-transaction" hook (with the
"prepared" state).
It seems not intuitive to me since the index and working dirs are
being updated before approving the transaction.
(the HEAD still points to an "old" reference while the
"post-index-change" hook is executing).

Thank you,
   Yaron

On Thu, Feb 25, 2021 at 7:37 AM Patrick Steinhardt [off-list ref] wrote:
On Wed, Feb 24, 2021 at 04:03:14PM -0500, Jeff King wrote:
quoted
On Wed, Feb 24, 2021 at 10:21:55PM +0200, Yaron Wittenstein wrote:
quoted
That indeed seems to do the trick.
I've done a little experiment and saw that when doing git reset the
hook gets called.

However, when switching branches the hook doesn't execute :(

I don't understand if it's intentional, since when I've moved to a new
branch HEAD pointed to another commit id.
The only workaround I see here is using the post-checkout hook in addition.
Hmm, I would have thought that the branch switch would trigger the hooks
because they're updating HEAD. I wonder if that is a bug (or lack of
feature :) ) in the transaction hooks, or something Patrick did
intentionally.

-Peff
It was done semi-intentionally, or at least with the knowledge that
symrefs aren't covered. This is mostly because they're not covered by
the reference transaction mechanism itself.

But this again reminds me that I still have to update the documentation
of the hook to at least make it more explicit what's currently covered
and what's not.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help