Thread (4 messages) flat view 4 messages, 2 authors, 2021-02-23

Re: 'git maintenance' won't work on bare repos

From: Eric Sunshine <hidden>
Date: 2021-02-23 05:04:11

On Mon, Feb 22, 2021 at 9:02 PM Clement Moyroud
[off-list ref] wrote:
So the proper solution is to do it from the bare clone itself.
However, 'git maintenance register' silently fails (with an 0 exit
code). There are two tell-tale signs:
1. 'git config --global --get maintenance.repo' returns '.'
2. There are no Crontab entries inserted.
I can confirm that problem 1 is a bug. However, I am unable to
reproduce problem 2.

Note that the crontab entry won't be created until you run `git
maintenance start`. Is it possible that you are forgetting that step?
(Be aware that `git maintenance start` will show a misleading "no
crontab for <user>" message if you don't already have a crontab file,
but the crontab entry will be created nevertheless, as evidenced by
`crontab -l`.)
To reproduce:
git init --bare test-me
git -C test-me maintenance register
git config --global --get maintenance.repo
I have a patch which fixes the problem with the bare repo path being
incorrectly registered as ".", but I still need to create a regression
test for it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help