Re: [PATCH v2 10/10] fsck.h: update FSCK_OPTIONS_* for object_name
From: Junio C Hamano <hidden>
Date: 2021-02-18 22:33:47
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Add the object_name member to the initialization macro. This was omitted in 7b35efd734e (fsck_walk(): optionally name objects on the go, 2016-07-17) when the field was added.
This is more of a Meh to me. If this were to change us to designated initializers and omit NULL and 0 initialization, it would be more interesting. Thanks.
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- fsck.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/fsck.h b/fsck.h index c77e8ddf10b..5d44ff1c8e3 100644 --- a/fsck.h +++ b/fsck.h@@ -47,8 +47,8 @@ struct fsck_options { kh_oid_map_t *object_names; }; -#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL, OIDSET_INIT } -#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL, OIDSET_INIT } +#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL, OIDSET_INIT, NULL } +#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL, OIDSET_INIT, NULL } /* descend in all linked child objects * the return value is: