Thread (2 messages) flat view 2 messages, 2 authors, 2021-02-19

Re: [PATCH 4/6] t7500: add tests for --fixup[amend|reword] options

From: Junio C Hamano <hidden>
Date: 2021-02-18 19:34:00

Charvi Mendiratta [off-list ref] writes:
quoted
quoted
+test_expect_success '--fixup=reword: -F give error message' '
+     echo "fatal: Only one of -c/-C/-F/--fixup can be used." >expect &&
+     test_must_fail git commit --fixup=reword:HEAD~ -F msg  2>actual &&
+     test_cmp expect actual
+'
Why?  If you can use -m msg, you should be able to use -F msgfile,
too, no?
Earlier I was thinking to let the `--fixup=amend:`  use the same options as of
current `--fixup=` . But yes I agree that there should be  -F option
also with `amend`
and `reword`.
Hmph, I was actually imagining the opposite---a context that does
not want to take -c/-C/-F would not want to take -m, either.

Why is -m so special, and a lot more importantly, what would a user
want to achieve by using "-m more-text" combined with this
"--fixup=reword:<commit>" or "--fixup=amend:<commit>" feature?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help