Re: [PATCH 1/2] t1450: robustify `remove_object()`
flat view
From: Junio C Hamano <hidden>
Date: 2021-02-10 20:37:04
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
quoted hunk
-test_expect_success 'setup: helpers for corruption tests' ' - sha1_file() { - remainder=${1#??} && - firsttwo=${1%$remainder} && - echo ".git/objects/$firsttwo/$remainder" - } && +sha1_file () { + git rev-parse --git-path objects/$(test_oid_to_path "$1") +}
Yeah, back when 90cf590f (fsck: optionally show more helpful info for broken links, 2016-07-17) originally introduced this pattern, we didn't have nicely abstracted helper, but now we do, and there is no reason not to use it. Nice.
quoted hunk
- remove_object() { - rm "$(sha1_file "$1")" - } -' +remove_object() {
Just like you did for the other one, let's insert SP before () for consistency here.
quoted hunk
+ rm "$(sha1_file "$1")" +} test_expect_success 'object with bad sha1' ' sha=$(echo blob | git hash-object -w --stdin) &&
Nicely done. Reviewed-by: Junio C Hamano <redacted>