Re: [PATCH v2 12/17] chunk-format: create read chunk API
From: Junio C Hamano <hidden>
Date: 2021-02-09 20:55:00
Derrick Stolee [off-list ref] writes:
In future series, additional protections could be added, and I would expect that to be done by converting callers of pair_chunk() into callers of read_chunk() with appropriate callback functions.
I am perfectly OK with leaving the interface as-is, as apparently it is sufficient for the current callers. It was just it looked insufficient for future callers that do not want to use the callback interface, i.e. learn the <ptr, size> pair with a single API call and then handle the data in that region itself, instead of preparing a callback function and calling read_chunk() on it. As C does not have closures, it gets quickly cumbersome if such a caller wants to share pieces of information with the callback function that is given to read_chunk(), but a caller that learns <ptr,size> from pair_chunk() and then works on the region of memory itself do nto have to worry about that.