Re: [PATCH v3 3/3] ref-filter: use pretty.c logic for trailers

On 2021-02-08 at 19:54:18, Junio C Hamano wrote:

Junio C Hamano [off-list ref] writes:

quoted

By the way, when merged to 'seen' (you can try the above that shows
%(subject) followed by %(trailers) with the tip of 'seen'), it dies
like this:

    $ git for-each-ref \
	--format="%(subject)%0a%(trailers:key=Signed-off-by:)" \
	refs/heads/js/range-diff-wo-dotdot
    free(): double free detected in tcache 2
    Aborted

There must be some interaction with another topic but I didn't dig
deeper.

It seems brian's bc/signed-objects-with-both-hashes topic alone has
the double-free issue, without the "trailers" topic.

    $ git checkout --detach bc/signed-objects-with-both-hashes
    $ make git
    $ ./git for-each-ref --format='%(subject)%(body)' refs/heads/maint
    free(): double free detected in tcache 2
    Aborted

So for now, you do not have to worry about it in your topic.  Of
course, you are very much welcome to help debugging and fixing it
;-)

I'll take a look.  Thanks for the heads up.
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US