Thread (1 message) 1 message, 1 author, 2021-02-04

Re: [PATCH 24/25] xdiff-interface: support early exit in xdiff_outf()

From: Junio C Hamano <hidden>
Date: 2021-02-04 18:17:35

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
Bridge the gap between the preceding "xdiff-interface: allow early
return from xdiff_emit_{line,hunk}_fn" change and the public
interface. This change was split off from the rest as it wasn't a
purely mechanical addition of "return 0".

Here we want to be able to abort early, but do so in a way that
doesn't skip the appropriate strbuf_reset() invocations.
Nice.
The use of -1 as a return value in the xdiff codebase for early
return, as we'll see more of in subsequent commits.
This is a non-sentence without a verb.  

I started reading the sentence and expected to see "The use of -1,
as opposed to something else, is because of thess deep reasons"
explained, but perhaps you forgot to conclude the sentence with such
an explanation?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help