On Thu, Feb 4, 2021 at 5:47 AM Phillip Wood [off-list ref] wrote:
On 02/02/2021 02:01, Eric Sunshine wrote:
quoted
Are the timestamps of these commits meaningful in this context?
I think we want to ensure that the timestamp of the commits created with
the different author are different from the previous commits. We ought
to be checking that the author date of the rebased commit matches the
author date of the original commit and not the author date of the fixup
commit created with the different author.
Such date-checking would indeed make sense and would remove any
potential confusion a reader might have concerning the manual
test_tick() calls. (It's not super important, but I still lean toward
dropping the test_tick() calls until they are actually needed simply
to avoid confusing readers. I asked about it in my review since their
purpose was unclear and I was genuinely wondering if I was overlooking
the reason for their presence. Future readers of the code may
experience the same puzzlement without necessarily having ready access
to the original author of the code from whom to receive an answer.)